Skip to content

Fix bugs in the pre-rad to have correct radii and radiation fluxes#566

Merged
climbfuji merged 3 commits into
NCAR:masterfrom
RuiyuSun:ruiyu/bugfix/prerad
Feb 19, 2021
Merged

Fix bugs in the pre-rad to have correct radii and radiation fluxes#566
climbfuji merged 3 commits into
NCAR:masterfrom
RuiyuSun:ruiyu/bugfix/prerad

Conversation

@RuiyuSun
Copy link
Copy Markdown
Contributor

@RuiyuSun RuiyuSun commented Feb 10, 2021

The pressure in the wrong unit is used in density calculation and passed into the effective radius calculation for the Thompson MP in the GFS_rrtmg_pre.F90. The bug fix has been tested in gfsv16_ccpp global experiments and RRFS experiments. The results show significant impacts on the SW radiative fluxes and subsequently temperature when Thompson MP is used.

Also included: bugfix in physics/radiation_clouds.f for iovr==3

Associated PRs:

#566
NOAA-EMC/ufsatm#238
ufs-community/ufs-weather-model#421

For regression testing, see ufs-community/ufs-weather-model#421

Copy link
Copy Markdown
Collaborator

@joeolson42 joeolson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

Copy link
Copy Markdown
Collaborator

@tanyasmirnova tanyasmirnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@climbfuji @RuiyuSun Thank you, Ruiyu, for noticing this bug that we overlooked. This fix does effect the cloud-radiation interaction with the use of Thompson MP, especially in the areas of subgrid clouds from MYNN PBL. Below are the diff plots of surface LW and SW radiation after 120-h fcst initialized at 5 Sept 2020 0 UTC (fix minus bug). The differences are the largest in the polar regions.
Screen Shot 2021-02-10 at 10 36 23 AM
Screen Shot 2021-02-10 at 10 35 16 AM

Copy link
Copy Markdown
Contributor

@hannahcbarnes hannahcbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this oversight. This change seems reasonable to me.

@RuiyuSun
Copy link
Copy Markdown
Contributor Author

@climbfuji @RuiyuSun Thank you, Ruiyu, for noticing this bug that we overlooked. This fix does effect the cloud-radiation interaction with the use of Thompson MP, especially in the areas of subgrid clouds from MYNN PBL. Below are the diff plots of surface LW and SW radiation after 120-h fcst initialized at 5 Sept 2020 0 UTC (fix minus bug). The differences are the largest in the polar regions.
Screen Shot 2021-02-10 at 10 36 23 AM
Screen Shot 2021-02-10 at 10 35 16 AM

Thanks for making the test!

@RuiyuSun
Copy link
Copy Markdown
Contributor Author

Thank you all for reviewing the change.

@climbfuji
Copy link
Copy Markdown
Collaborator

Thank you all for reviewing the change.

I'll look for a suitable spot in the commit queue to get this merged.

@RuiyuSun
Copy link
Copy Markdown
Contributor Author

RuiyuSun commented Feb 10, 2021 via email

@dustinswales
Copy link
Copy Markdown
Member

@ligiabernardet @climbfuji Just FYI
I can confirm that this bug doe not impact the RRTMGP-2-Thompson MP coupling. See lines 183-185, https://github.com/NCAR/ccpp-physics/blob/master/physics/GFS_rrtmgp_thompsonmp_pre.F90

@ligiabernardet
Copy link
Copy Markdown
Collaborator

ligiabernardet commented Feb 11, 2021 via email

@ericaligo-NOAA
Copy link
Copy Markdown
Contributor

ericaligo-NOAA commented Feb 12, 2021 via email

@hannahcbarnes
Copy link
Copy Markdown
Contributor

I am not an expert in polar clouds, but I remember I had a similar question a few years. Surprising there is quite a bit of literature about mixed-phase clouds in the arctic. (Here is one example https://www.nature.com/articles/ngeo1332). I am not sure where the largest impact from this code change should be, but having at least some impact in polar regions seems reasonable to me.

@ericaligo-NOAA
Copy link
Copy Markdown
Contributor

ericaligo-NOAA commented Feb 12, 2021 via email

@yangfanglin
Copy link
Copy Markdown

yangfanglin commented Feb 12, 2021 via email

@RuiyuSun
Copy link
Copy Markdown
Contributor Author

RuiyuSun commented Feb 15, 2021 via email

…iyu/bugfix/prerad

This is update ruiyu/bugfix/prerad with the most recent version of the NCAR master.
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Will merge when regression testing is completed.

@climbfuji climbfuji merged commit d884fb1 into NCAR:master Feb 19, 2021
HelinWei-NOAA pushed a commit to HelinWei-NOAA/ccpp-physics that referenced this pull request Feb 26, 2023
…leanup (NCAR#566)

* update submodule pointer to Man's ccpp-physics PR#944 branch: ccppv6 doc update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants